Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH154: Add SourceLink support #155

Merged
merged 3 commits into from
Apr 30, 2020
Merged

GH154: Add SourceLink support #155

merged 3 commits into from
Apr 30, 2020

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented Apr 30, 2020

Fixes #154.

Note: switches from separate snupkg to an embedded portable pdb in the main nupkg. Just an idea. Have a look and let me know what you think.

Also, I can't seem to build locally, so I'm pushing a PR to see if AppVeyor will build it. 馃槢

@gitfool
Copy link
Contributor Author

gitfool commented Apr 30, 2020

@mariotoffia please review. I had to bump GitVersionTask to the latest beta to get the build to work.

@mariotoffia mariotoffia merged commit ccf65e6 into mariotoffia:master Apr 30, 2020
@gitfool gitfool deleted the gh154 branch April 30, 2020 06:51
@mariotoffia
Copy link
Owner

Many thanks for this neat contribution! :)

@gitfool
Copy link
Contributor Author

gitfool commented Apr 30, 2020

@mariotoffia could you do me a favor and release another version so I can use it with symbols? 馃槈

@gitfool
Copy link
Contributor Author

gitfool commented Apr 30, 2020

I can now debug step into prerelease version 2.7.60-beta.127! 馃槂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SourceLink support
2 participants
@gitfool @mariotoffia