Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: marian-nmt/marian
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: marian-nmt/marian
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ug-issue-425
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 1 commit
  • 4 files changed
  • 1 contributor

Commits on Mar 22, 2019

  1. Don't close named pipes during corpus reset. 

    The corpus reset reopened input files for corpora. So files were opened once during
the construction of the Corpus instance, then closed and repopened during data->reset()
triggered by BatchGenerator::prepare(false). With normal files that's not a problem,
but if the "file" is a named pipe, the closing triggers a SIGPIPE (broken pipe) on
the writing end of the pipe. With this commit, Corpus::reset() leaves open pipes
alone.
    @ugermann
    ugermann committed Mar 22, 2019
    Configuration menu
    Copy the full SHA
    fd4f2a9 View commit details
    Browse the repository at this point in the history
Loading