forked from inaka/erlang_guidelines
-
Notifications
You must be signed in to change notification settings - Fork 0
/
smaller_functions.erl
31 lines (25 loc) · 836 Bytes
/
smaller_functions.erl
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
-module(smaller_functions).
-export([bad/0, bad/1, good/0, good/1]).
%% @doc function with just a case
bad(Arg) ->
case Arg of
this_one -> should:be(a, function, clause);
and_this_one -> should:be(another, function, clause)
end.
%% @doc usage of pattern matching
good(this_one) -> is:a(function, clause);
good(and_this_one) -> is:another(function, clause).
%% @doc function with an internal case
bad() ->
InitialArg = some:initial_arg(),
InternalResult =
case InitialArg of
this_one -> should:be(a, function, clause);
and_this_one -> should:be(another, function, clause)
end,
some:modification(InternalResult).
%% @doc usage of function clauses instead of an internal case
good() ->
InitialArg = some:initial_arg(),
InternalResult = good(InitialArg),
some:modification(InternalResult).