Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

Add support for POST, PUT, and DELETE methods #6

Closed
alulsh opened this issue Jun 6, 2017 · 4 comments
Closed

Add support for POST, PUT, and DELETE methods #6

alulsh opened this issue Jun 6, 2017 · 4 comments

Comments

@alulsh
Copy link
Member

alulsh commented Jun 6, 2017

Currently this wrapper only supports GET requests for the JSS REST API. We should add support for other HTTP methods such as POST, PUT, and DELETE.

For example, we can add a post function to the JamfApiClient object prototype and update the method for the request from GET to POST.

For these HTTP methods in particular we should add solid test fixtures for Nock as well to avoid having to test on a production API.

We should also add code samples and update the README with useful documentation for these other methods.

/cc @mapbox/security @ianshward

@ururk
Copy link

ururk commented Aug 9, 2018

Would there be any benefit to adding all of the JAMF resources as callable methods - in line with what this Python library does:

https://github.com/eventbrite/Casper-API-Tools Scrap this comment - it looks like you refactored to move away from this style of API wrapper - #2.

At the moment I've added PUT and POST (will PR soonish - need to figure out how to add test fixtures first). I submitted the PR. Would appreciate some guidance on what test fixtures would be useful.

@Elwyn1979
Copy link

_@alush A bit confused. Is there support now for PUT and POST request. I usually _use bash for my api calls but now need to do a request with javascript. Thanks.

@trevorspecht
Copy link
Contributor

Hi @ururk and @Elwyn1979. @alulsh is no longer maintaining this repo, and Mapbox plans to archive the repo since it is not in use. Since it is public, however, and has been published as an NPM module, I plan to keep it active outside of Mapbox in my own Github account. I have not found another Node.js SDK for the Jamf API, so I think there is public benefit to keeping this active and maintained.

@ururk thanks for the PR, I will take a look and aim to get it merged and deployed to NPM before too long.

@trevorspecht
Copy link
Contributor

any future updates or maintenance will be done at this library's new home: https://github.com/trevorspecht/jamf-sdk-node

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants