Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Data-driven runtime styling for Node #8495

Closed
1ec5 opened this issue Mar 22, 2017 · 3 comments
Closed

Data-driven runtime styling for Node #8495

1ec5 opened this issue Mar 22, 2017 · 3 comments
Labels
feature GL JS parity For feature parity with Mapbox GL JS Node.js node-mapbox-gl-native runtime styling

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 22, 2017

Basic runtime styling support was added to the Node module in #5318, but it doesn’t include property functions, which were implemented in mbgl in #7372. Currently, you can set property functions via style JSON. This issue tracks adding a way to manipulate them via the runtime styling API.

/cc @kkaefer @bsudekum

@1ec5 1ec5 added feature GL JS parity For feature parity with Mapbox GL JS Node.js node-mapbox-gl-native runtime styling labels Mar 22, 2017
@jfirebaugh
Copy link
Contributor

Can you say more specifically what you see as missing? The existing bindings pass most of the tests in https://github.com/mapbox/mapbox-gl-js/tree/master/test/integration/render-tests/runtime-styling, which include tests that use property functions.

@1ec5
Copy link
Contributor Author

1ec5 commented Mar 22, 2017

@jfirebaugh, I was referring to passing property functions into setPaintProperty() from the JavaScript side, going off the discussion in #7372 (comment). From a cursory look at node_map.cpp, it didn’t look like there was support for property functions, but if there’s conversion magic going on, we can close this ticket and call it done. 😄

@jfirebaugh
Copy link
Contributor

jfirebaugh commented Mar 22, 2017

Yep, that should work -- it's handled by the logic in style/conversion/function.hpp.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature GL JS parity For feature parity with Mapbox GL JS Node.js node-mapbox-gl-native runtime styling
Projects
None yet
Development

No branches or pull requests

2 participants