Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

lib/carto/mml.js: FIX: Error: Function yaml.safeLoad is removed in js… #514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

josch
Copy link

@josch josch commented Dec 10, 2021

…-yaml 4. Use yaml.load instead, which is now safe by default.

This makes the code compatible with js-yaml >= 4.

…-yaml 4. Use yaml.load instead, which is now safe by default.
@gravitystorm
Copy link
Contributor

This PR, as it currently stands, would be using the unsafe load method from js-yaml 3.x . We would need to make the change from safeLoad to load at the same time as upgrading the package.json file to use the 4.x series.

@josch
Copy link
Author

josch commented Dec 13, 2021

This PR, as it currently stands, would be using the unsafe load method from js-yaml 3.x . We would need to make the change from safeLoad to load at the same time as upgrading the package.json file to use the 4.x series.

Yes. I'll leave it up to you to make the switch. I'm just forwarding a patch that I apply to the Debian package of carto because in Debian we can only ship one version of each package, so we have carto use the latest version of js-yaml which is 4.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants