Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Potential abuse for when user-signup is disabled but magic-link is enabled, #4739

Closed
1 task done
Nathan13888 opened this issue Jun 9, 2024 · 3 comments
Closed
1 task done
Assignees
Labels
🐛bug Something isn't working

Comments

@Nathan13888
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current behavior

Similar to #1792

Invalid users are sent email magic-codes on demand on the login page, despite signups are disabled.

Expected Behaviour: user is warned that signups are disabled, and no email is sent.

image

Steps to reproduce

  • On latest tag (deployed today) to k8s.
  • Set the following in Postgres:
    image
  • Visit login / and enter non-existent email. Magic code is sent to user.

Environment

Production

Browser

Mozilla Firefox

Variant

Self-hosted

Version

v0.21.0

@Nathan13888 Nathan13888 added the 🐛bug Something isn't working label Jun 9, 2024
@pushya22 pushya22 assigned mguptahub and unassigned srinivaspendem and pushya22 Jun 10, 2024
@pablohashescobar
Copy link
Collaborator

@Nathan13888, the magic code would be sent but the user won't be able to create account. We will add an additional validation so that even the magic code is not being sent.

@Nathan13888
Copy link
Author

Yup, you're correct, that's the behavior I've observed too.

@pushya22
Copy link
Collaborator

pushya22 commented Jul 9, 2024

Hi @Nathan13888 closing the issue since the feature is working as intended. Please re-open in case of any further queries.

@pushya22 pushya22 closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants