-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session stores require @classic #2267
Comments
@marcoow Is there a way to avoid using import classic from 'ember-classic-decorator';
import Cookie from 'ember-simple-auth/session-stores/cookie';
@classic
export default class ApplicationSessionStore extends Cookie {} There is an ongoing issue in And I can't remove Any suggestion would be greatly appreciated, thanks! |
The fix for ember-classic-decorator #83 has been fixed and merged so this is no longer a blocker to Ember 4. |
I am in the process of updating our app to I was wondering if I could remove the The app crashes with this error message in the console:
The code triggering this error: import Cookie from 'ember-simple-auth/session-stores/cookie';
export default class ApplicationSessionStore extends Cookie {
cookieExpirationTime = 30 * 24 * 60 * 60;
} Are there any plans to convert classes from EmberObject to native classes at some point? This is the last A big thank you to the maintainers for your hard work! |
Update: we managed to remove the Previously, removing the With that said, I believe we can close this issue @maxwondercorn. |
I forgot to check back on this issue 😔 but I'm glad it worked finally. I'll close this issue, but feel free to report if there's something wrong still. |
Session stores extend from the Ember object so you do need the
@classic
decorator when using native class syntax.This should be documented in the README. If you like, I can create a PR.
The text was updated successfully, but these errors were encountered: