fix: File name injections via Content-ID header
#487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content-ID header
stypr
reviewed
Aug 7, 2024
| this._currentNode.meta.contentId = originalContentId | ||
| ? (crypto.createHash('md5').update(originalContentId).digest('hex') + | ||
| '-' + | ||
| originalContentId.replace(/[:/\\]+/g, '-')) |
There was a problem hiding this comment.
I think originalContentId.replace(/(\.\.|:|\/|\\)+/g, '-') should be better
stypr
suggested changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467
Fixes CVE-2024-27448
This is how we're fixing this:
/, back-slash and:characters in theContent-IDheader with-.Content-IDheader, so attachments with names../file.txtand..-file.txtdon't overwrite each other.If this is an approach you guys would be interested in taking forward, I'll look into adding tests to ensure we don't regress on this. Let me know. Thanks for all your work on this project.
The tests are failing because the
cid:...in HTML messages aren't getting replaced with the URLs to the image attachments themselves. I'm not sure where this replacement is happening, if I can find it, I think I can fix it.