Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use-after-free crash #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nyanpasu64
Copy link

Fixes #48. I've converted two NTFS drives and the program hasn't crashed.

Unfortunately, the resulting btrfs filesystem triggered a kernel warning and went into read-only mode after mere minutes of using digiKam's SQLite database on it.

@maharmstone
Copy link
Owner

Unfortunately, the resulting btrfs filesystem triggered a kernel warning and went into read-only mode after mere minutes of using digiKam's SQLite database on it.

Could you paste the output of btrfs check please? My guess is that this is something related to fsync...

@nyanpasu64
Copy link
Author

Here are the kernel warnings and btrfs check --repair after the corruption (I do not have btrfs check --repair before the corruption): https://gist.github.com/nyanpasu64/830d9bd57bb3aa7999ebae105a0b2e96

I got an error and read-only disk, btrfs check found and repaired errors, but digiKam continued sending the disk into read-only mode even though btrfs check did not find errors.

I've restored a Clonezilla backup (didn't try ntfs2btrfs --rollback) and reverted my disk to NTFS for now. I could try reconverting and running btrfs check, but I'm not excited to risk data loss and gamble on Clonezilla working again (and Clonezilla will wear my SSD to an extent, ntfs2btrfs not so much).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crashes on a use-after-free caused by vector iterator invalidation
2 participants