Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to a Lerna Monorepo #94

Closed
2 tasks done
smithki opened this issue May 23, 2020 · 1 comment · Fixed by #101
Closed
2 tasks done

Refactor to a Lerna Monorepo #94

smithki opened this issue May 23, 2020 · 1 comment · Fixed by #101
Assignees
@smithki
Labels
✨Feature Request released This issue/pull request has been released.

Comments

@smithki
Copy link
Contributor

smithki commented May 23, 2020 •
edited
Loading

✅ Prerequisites

  • Did you perform a cursory search of open issues? Is this feature already requested elsewhere?
  • Are you reporting to the correct repository (magic-sdk)?

✨ Feature Request

Soon we will be offering open-source Magic SDK extensions. To support these upcoming new libraries more easily, we should refactor to a monorepo using Lerna.

EDIT:

Another great reason for this feature is the blockers encountered during the Redwood JS integration. See the open PR for a more detailed explanation.
@smithki smithki mentioned this issue May 24, 2020
Closed
@smithki smithki self-assigned this May 29, 2020
@smithki smithki mentioned this issue Jun 2, 2020
Merged
4 tasks
@Ethella Ethella mentioned this issue Jun 5, 2020
Closed
@smithki
Copy link
Contributor Author

smithki commented Oct 22, 2020

🚀 Issue was released in @magic-sdk/[email protected], @magic-sdk/[email protected], @magic-sdk/[email protected], [email protected] 🚀

@smithki smithki added the released This issue/pull request has been released. label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@smithki smithki

Labels
✨Feature Request released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor to a Lerna Monorepo magiclabs/magic-js
1 participant
@smithki