Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Report: Endless Cookie Rendering Loop #733

Open
2 tasks done
Adebesin-Cell opened this issue Mar 25, 2024 · 5 comments
Open
2 tasks done

Bug Report: Endless Cookie Rendering Loop #733

Adebesin-Cell opened this issue Mar 25, 2024 · 5 comments

Comments

@Adebesin-Cell
Copy link

Adebesin-Cell commented Mar 25, 2024

✅ Prerequisites

  • Did you perform a cursory search of open issues? Is this bug already reported elsewhere?
  • Are you reporting to the correct repository (magic-sdk)?

🐛 Description

Upon initializing the Wagmi connector into my project, I noticed a peculiar behavior related to cookie rendering.

🧩 Steps to Reproduce

  1. Integrate the Wagmi connector into the project.
  2. Initialize the Wagmi connector within the codebase.
  3. Observe the rendering behavior of cookies.
  4. Notice the continuous rendering of cookies without halt.

🤔 Expected behavior

I expected the cookies to render appropriately upon initialization and to cease rendering once initialized. There should be no continuous loop of cookie rendering.

😮 Actual behavior

The cookies enter an infinite rendering loop, continually rendering without cessation. This behavior triggers an error marked with number of times it has rendered, indicating that the cookies have been rendered an excessive number of times. Consequently, this error warns that third-party cookie functionality may be blocked.

💻 Code Sample

https://stackblitz.com/edit/stackblitz-starters-bbb65e?file=app%2Fpage.tsx,app%2Fconfig.ts,package.json

Screenshots

Screenshot 2024-03-25 at 5 38 25 PM

🌎 Environment

Software Version(s)
magic-sdk 18.3.0
Browser Vivaldi
yarn >=1.22.0
Operating System Mac OS Ventura 13.1 (22C65)
@Royal-lobster
Copy link

This seems to be a issue on almost all sites that has magic login integrations

image

image image image

@hubagaspar91
Copy link

Yep, we're experiencing this issue as well, we recently upgraded https://github.com/magiclabs/wagmi-magic-connector in our project from 1.1.5 to 2.0.0, which it seems also comes with a magic SDK version upgrade.

@TheGreatAlgo
Copy link

Having same issue too. we were on 8.1.0 (time for upgrade lol) and having the issue

@mjafri118
Copy link

is there a fix to this? upgrading does not seem to help.

@Wyxuch
Copy link

Wyxuch commented Jun 25, 2024

Hi there!
this bug still occurring in 28.0.7. Is there any chance to fix that in the upcoming updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants