Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with magic-ext/auth in react native? #583

Open
thatportugueseguy opened this issue Jul 18, 2023 · 4 comments
Open

Issue with magic-ext/auth in react native? #583

thatportugueseguy opened this issue Jul 18, 2023 · 4 comments

Comments

@thatportugueseguy
Copy link

Hello,

I'm developing an app with react native and wanted to integrate with Magic, but i'm hitting an issue with magic-ext/auth where i get an error that the imported file can't be found. Most specifically: ...dist/react-native/index.native.js.

I'm fairly new to developing in react native, so there might be something that i missed here, but it seems that this line is pointing react native in the wrong direction, as there isn't any dist build directory with the name react-native. I have looked at the expo packages and they don't have this react-native prop.

The issue seems to be with the following line in package.json:

"react-native": "./dist/react-native/index.native.js",

At the moment, the fix i have for it is pointing the react-native prop to the index.js file, or simply deleting the line completely.

Am i doing something wrong when installing this module? AFAIU, I don't think so.

Also, it seems that there is something similar on the webauthn extension too. There is a index.native.ts file, but the reference doesn't seem to be pointing to the right file, and it seems that there isn't a dist/react-native folder too

"react-native": "./dist/react-native/index.native.js",

Please let me know if these lines are something leftover from a refactor or something of the like, and if you'd like me to submit a PR pointing those lines to the right files, or changing them in some other way.

Thank you

@nicomanzato
Copy link

I'm having the same issue, is there a workaround or a fix coming up for this issue?

@ayv8er
Copy link

ayv8er commented Jul 24, 2023

Did you guys react to the deprecation notice when you call any of the auth methods, and use the auth extension?

@thatportugueseguy
Copy link
Author

Yes, this is using the auth extension, but has nothing to do with the deprecation notice. It's a different error.

@ayv8er
Copy link

ayv8er commented Jul 31, 2023

Is this reproducible when using Magic SDK without the auth extension?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants