-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update type signature of RpcProviderModule to implement Ethers's AbstractProvider #373
Comments
Hi @charesbast and thank you for submitting this issue. I've gone ahead and marked this as a feature request. Will update this thread when we implement the requested changes! |
Hey! I am seeing this issue with the latest Magic SDK & React Native. Are you sure @am-hernandez this was a feature request, not an actual bug? It seems that this is recommended way of setting things up, as per your documentation. Current workaround is to cast to |
@am-hernandez this is still an issue... |
✅ Prerequisites
magic-sdk
)?🐛 Description
Similar to #83, we have the same problem with ethers library:
magic.rpcProvider
type does not match the expected param type ofethers.providers.Web3Provider
constructor.🤔 Expected behavior
Being able to write
const provider = new ethers.providers.Web3Provider(magic.rpcProvider);
without a compilation error💻 Code Sample
🌎 Environment
magic-sdk
ethers
yarn
The text was updated successfully, but these errors were encountered: