Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhpMd #52

Closed
3 tasks
sashas777 opened this issue May 11, 2020 · 0 comments · Fixed by #58
Closed
3 tasks

PhpMd #52

sashas777 opened this issue May 11, 2020 · 0 comments · Fixed by #58
Assignees
@sashas777
Labels
to do Ready to be worked on
Projects
Tests

Comments

@sashas777
Copy link
Collaborator

Run vendor/bin/phpmd app/code/Magetarian/CustomerTwoFactorAuth/ text dev/tests/static/testsuite/Magento/Test/Php/_files/phpmd/ruleset.xml

  • Magetarian/CustomerTwoFactorAuth/Controller/Customer/Providers.php:84 The method execute() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.

  • Magetarian/CustomerTwoFactorAuth/Plugin/Customer/Controller/Ajax/LoginPlugin.php:89 The method aroundExecute() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.

  • Magetarian/CustomerTwoFactorAuth/Plugin/Customer/Controller/Ajax/LoginPlugin.php:89 The method aroundExecute() has an NPath complexity of 264. The configured NPath complexity threshold is 200.
@sashas777 sashas777 added this to To do in Development via automation May 11, 2020
@sashas777 sashas777 added this to To Do in Tests via automation May 11, 2020
@sashas777 sashas777 removed this from To do in Development May 11, 2020
@sashas777 sashas777 added the to do Ready to be worked on label May 11, 2020
@sashas777 sashas777 linked a pull request May 29, 2020 that will close this issue
[WIP] Authy WIP #58
Merged
@sashas777 sashas777 self-assigned this May 29, 2020
Tests automation moved this from To Do to Done May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sashas777 sashas777

Labels
to do Ready to be worked on
Projects
No open projects
Tests
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Authy WIP magetarian/customerTwoFactorAuth
1 participant
@sashas777