-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trailing dot in name gets an unfilled byte #62
Comments
Ah, I see. Good find. Wanna PR a fix? |
I’ve gotten started but the encodeLength method is called in several places and I need to be confident I’m not going to break anything and that the tests are correct (plus it’s slow going since I’m not very familiar with JS :) ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a question's name field has a trailing dot (e.g.
1.0.0.127.in-addr.arpa.
), the length is computed before the trailing dot is dropped. This results in a buffer that's one byte longer than necessary, and which has a trailing byte that goes unfilled. For example,results in a buffer len of 56, but only 55 bytes are written.
The relevant code is here:
This was discovered while diagnosing #52 (also trying to diagnose mafintosh/multicast-dns#13).
As a workaround, manually dropping the trailing dot in constructing the address seems to work (but not to fix my issue, oh well.)
The text was updated successfully, but these errors were encountered: