-
-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request for typescript definition file #59
Comments
Incomplete, but here: https://www.npmjs.com/package/@types/dns-packet |
@martinheidegger would you be open to supporting types directly in this package? definitelyTyped is huge and adding types is a significant pain. (check out the PR checklist at DefinitelyTyped/DefinitelyTyped#67294) |
I don't think it will make it in the package |
@martinheidegger would you mind elaborating? Are you trying to keep modifications to this package low or worried about pushing back against a TS conversion? we could add types in this package without changing the JS code at all (just including the index.d.ts from DefinitelyTyped). |
I would accept a reasonable PR that adds What is the current best practice to validate those files? https://github.com/tsdjs/tsd or is there something better? |
No description provided.
The text was updated successfully, but these errors were encountered: