Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mousepad: Update to 0.6.2 #23674

Closed
wants to merge 1 commit into from

Conversation

qwertychouskie
Copy link
Contributor

Description

Updates Mousepad to 0.6.2, enabling GTK3 in the process.

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.4.1 23E224 arm64
Xcode 15.3 15E204a

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@qwertychouskie
Copy link
Contributor Author

The build error is https://trac.macports.org/ticket/68854. I'll send in a PR to update libxfce4*, which should trigger a rebuild and therefore fox the issues.

@qwertychouskie
Copy link
Contributor Author

PR opened: #23687

Once that PR is merged I'll rebase this one and it should work.

xfce/mousepad/Portfile Outdated Show resolved Hide resolved
@qwertychouskie
Copy link
Contributor Author

  DEBUG: system: /opt/local/bin/gtk-update-icon-cache -f -t /opt/local/share/icons/hicolor
  sh: /opt/local/bin/gtk-update-icon-cache: No such file or directory
  Command failed: /opt/local/bin/gtk-update-icon-cache -f -t /opt/local/share/icons/hicolor
  Exit code: 127
  Error: Failed to activate mousepad: command execution failed

Hmm, it works fine on my system, perhaps there's a missing dep/builddep?

@qwertychouskie
Copy link
Contributor Author

OK, now it's failing locally as well. What's weird is that this build worked before the rebase on #23687...

@qwertychouskie
Copy link
Contributor Author

qwertychouskie commented Apr 26, 2024

Ah, it's because gtk2 is no longer installed, and gtk3's gtk-update-icon-cache is called gtk-update-icon-cache-3.0. On my Ubuntu system, the main gtk-update-icon-cache is built from the GTK3 sources. Perhaps the gtk2 version should be renamed to gtk-update-icon-cache-2.0, and the gtk3 version renamed to gtk-update-icon-cache? GTK2 is long deprecated, and the list of things still using it is shrinking over time. In fact, as I get to updating more XFCE stuff, that list is going to be even smaller.

@mascguy Since you maintain the GTK packages, what are your thoughts?

@ryandesign
Copy link
Contributor

Perhaps the gtk2 version should be renamed to gtk-update-icon-cache-2.0, and the gtk3 version renamed to gtk-update-icon-cache?

And then update the references them all the ports and build systems that are already familiar with their existing names? Seems like a lot of work for no benefit.

@mascguy
Copy link
Member

mascguy commented May 17, 2024

Perhaps the gtk2 version should be renamed to gtk-update-icon-cache-2.0, and the gtk3 version renamed to gtk-update-icon-cache?

And then update the references them all the ports and build systems that are already familiar with their existing names? Seems like a lot of work for no benefit.

That is my concern as well.

@mohd-akram
Copy link
Member

IMO update this to use gtk-update-icon-cache-3.0 until we figure out what to do with #23731. The fewer GTK2 ports the easier any kind of transition would be.

@mohd-akram mohd-akram mentioned this pull request May 23, 2024
12 tasks
@reneeotten
Copy link
Contributor

feel free to reopen this PR once it's actually building.

@reneeotten reneeotten closed this Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants