Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope.js removes Array.prototype.toJSON #588

Open
hmmdeif opened this issue Jan 21, 2016 · 0 comments
Open

Scope.js removes Array.prototype.toJSON #588

hmmdeif opened this issue Jan 21, 2016 · 0 comments
Labels
Milestone

Comments

@hmmdeif
Copy link

hmmdeif commented Jan 21, 2016

Ln:126 it's set as undefined but it's never restored. It was done for #482 but if any sites require that function then they can't use it since it's not overridden anywhere.

Took me a while to figure out why my site wasn't rendering correctly so it's a particularly nasty issue since it's quite subtle. I think we should be checking for Prototype (up to v1.7) and Mootools if they are the only things causing issues rather than removing it from the window global completely.

@macbre macbre added the bug label Jan 30, 2016
@macbre macbre added this to the v1.15 milestone Jan 30, 2016
@macbre macbre modified the milestones: Roadmap, v1.15, v1.16 Mar 25, 2016
@macbre macbre modified the milestones: v1.16, Roadmap Jul 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants