-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wait-for-selector not working on some pages #517
Comments
@gmetais, can't reproduce on the latest |
Yes, still broken for me on the latest devel branch. As you can see in the following verbose log, some
|
Maybe I should mention that one of the tests fails every time on my computer. Maybe it could be related to the above bug?
|
@gmetais, did you try reproducing in on a different machine? Can you run
|
I'll try on another machine. |
It's working properly on an Ubuntu VM:
|
@gmetais, thanks for the investigation. I"ll try to refactor the test to be more deterministic and work across platforms. |
Hi @macbre !
I'm still having a issue with the option
--wait-for-selector
on some pages. The selector doesn't exist on the page but the test ends early.Example:
phantomas --url=http:https://www.github.com --timeout=60 --phone --wait-for-selector=".foo.bar" --verbose
The problem seems to be located here:
https://github.com/macbre/phantomas/blob/devel/core/phantomas.js#L460
with this
done()
function being called twice.Sorry, no pull request today as I can't find the reason behind the problem...
The text was updated successfully, but these errors were encountered: