Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offenders not tested in integration tests #1305

Open
gmetais opened this issue Aug 13, 2023 · 0 comments
Open

Offenders not tested in integration tests #1305

gmetais opened this issue Aug 13, 2023 · 0 comments

Comments

@gmetais
Copy link
Contributor

gmetais commented Aug 13, 2023

Cześć there!

You recently changed the following line from deepStrictEqual to notStrictEqual. As a result, whatever is set in the expected offenders is considered valid.

phantomas/test/integration.test.js

Line 127 in 1c22c62

assert.notStrictEqual(

That's handy, but you probably wanted to use deepEqual instead?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gmetais