-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring : Confirmations controller - useless if redirect_url
condition
#1611
Comments
if
conditionif redirect_url
condition
Also, it could be nice to say if email is already confirmed. I know it's possible to get the answer by calling this:
So it would be nice to specify if |
Version: 1.2.2
in this section
devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb
Lines 29 to 33 in eeed642
I was wondering why we are checking
if redirect_url
because it's necessary of havingDeviseTokenAuth.default_confirm_success_url
orparams[:redirect_url]
set.In other words, imagine having this method returning nil
devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb
Lines 82 to 87 in eeed642
It means that the sign_up flow would failed in this section
devise_token_auth/app/controllers/devise_token_auth/confirmations_controller.rb
Lines 22 to 25 in eeed642
and throw an exception of type
ArgumentError
sayingbad argument (expected URI object or URI string)
.Maybe I missed something?
The text was updated successfully, but these errors were encountered: