Add Renderer.renderCurrentBuffer() to tackle "First Frame Problem". #19
Conversation
| /** | ||
| * "Renders" what is in the buffer at the moment, blocking the caller thread. | ||
| * | ||
| * Main purpose of this API is to add a way of solving ["First Frame Problem"](https://github.com/lyft/domic/issues/14). |
There was a problem hiding this comment.
Is markdown with links supported? Otherwise this might look weird
There was a problem hiding this comment.
Renders fine in IntelliJ, afaik kotlindoc supports most of markdown
| import java.util.concurrent.TimeUnit.MILLISECONDS | ||
| import java.util.concurrent.atomic.AtomicInteger | ||
|
|
||
| class AndroidRenderer( | ||
| private val choreographer: Choreographer = Choreographer.getInstance(), | ||
| timeScheduler: Scheduler = Schedulers.computation(), | ||
| bufferTimeWindowMs: Long = 8, // We'll adjust if needed. | ||
| private val buffer: RenderingBuffer<Action> = RenderingBufferImpl() | ||
| private val buffer: RenderingBuffer<Action> = RenderingBufferImpl(), | ||
| private val renderingThreadChecker: Callable<Boolean> = Callable { Looper.myLooper() == Looper.getMainLooper() } |
There was a problem hiding this comment.
consider renaming this to mainThreadChecker, to avoid any confusion wrt RenderThread on android.
There was a problem hiding this comment.
heh, that was original name, but then I figured that it's too implementaiton
specific
but now I think it's fair for AndroidRenderer renderer to have such parameter name since it's AndroidRenderer and not just Renderer
| */ | ||
| @MainThread | ||
| override fun renderCurrentBuffer() { | ||
| if (renderingThreadChecker.call() == false) { |
There was a problem hiding this comment.
maybe you can just throw inside of the Callable? Would make the callsites cleaner.
There was a problem hiding this comment.
Well, it's a bit harder to define an interface where no-op means ok and throws means expected error, also if we decide to use renderingThreadChecker.call() somewhere in the hot path and handle wrong thread case differently, exceptions will quickly become a performance bottleneck
There was a problem hiding this comment.
All good points - especially performance in hot path 👍
Closes #14.