Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in unace file listing parser #187

Open
tartpvule opened this issue Oct 6, 2020 · 0 comments
Open

Error in unace file listing parser #187

tartpvule opened this issue Oct 6, 2020 · 0 comments

Comments

@tartpvule
Copy link

Expected Behavior

Scrubbed output below in the "Context" section. Sorry, private data.
Listing of ACE files should only show "real" files, without including a "file" named "bytes (compressed x.xxxX)".

Current Behavior

A "file" named "bytes (compressed x.xxxX)" is shown in the file listing UI.

Possible Solution

Fix process_line function in fr-command-ace.c to stop when it encounters a line that starts with "listed: "

Steps to Reproduce (for bugs)
  1. Get a .ace compressed archive somehow, or download WinAce Trial (like from softpedia.com) and make an archive. Calling this "test.ace".
  2. Run unace v test.ace from a terminal and observe the output
  3. Open "test.ace" from lxqt-archiver and observe the file listing
  4. Observe that bytes (compressed x.xxxx) is shown as a filename
Context

Tried opening an ancient ACE archive from early 2000s with lxqt-archiver in 2020.
Output with filenames and numbers scrubbed:

UNACE v2.5     Copyright by ACE Compression Software       Jan 25 2020 21:01:27

processing archive /tmp/scrubbed.ace
created on xx.xx.xxxx with ver 2.0 by
*UNREGISTERED VERSION*
Contents of archive scrubbed.ace

  Date    Time     Packed      Size  Ratio  File

xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename1
xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename2
xx.xx.xx xx:xx     xxxxxxx   xxxxxxx   xx%  filename3

listed: 3 files, totaling x.xxxX bytes (compressed x.xxxX)

Using "unace 2.5-11" package from ArchLinux, which is "non-free" version

System Information
  • Distribution & Version: ArchLinux
  • Kernel: Irrelevant
  • Qt Version: Irrelevant
  • libqtxdg Version: Irrelevant
  • lxqt-build-tools Version: Irrelevant
  • Package version: lxqt-archiver 0.2.0

Best Regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant