-
-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pool-specifc disk limits in projects #906
Comments
I'd like to work on this issue! |
Cool, I assigned it to you! |
Sorry about the delay, but from what I understand I'll have to update incus/cmd/incusd/api_project.go Line 1293 in 7031065
with an additional field for I saw that the function gets called as part of incus/cmd/incusd/api_project.go Line 302 in 7031065
but that seems to just create an entry in the database. Is there something else that needs to be done outside of that? |
Sorry for the delay here. Note that the key is really meant to be You're correct that the main spot where this needs to be added is in The actual enforcement however is done in |
@awalvie any luck with this one? |
Sorry about the delay here @stgraber, was away on vacation the last couple weeks. I'll start working on this shortly. But if its blocking a release please feel free to remove me as the assignee. I'll send a message to get the issue assigned again if no one has picked it up! |
Nope, no rush, was just wondering. I hope you had a good vacation! |
The current
limits.disk
resource limit on projects only allows restricting the overall disk footprint, this is fine in many environments but for those of us with clusters having different class of storage, like:Having all storage treated equal isn't ideal and so having per-pool limits would be preferable.
The easiest way would be to not only have
limits.disk
but alsolimits.disk.pool.XYZ
whereXYZ
in this case would be one ofhdd
,local
,shared
orssd
.A limit of
0
would prevent the use for a storage pool entirely and should result in its exclusion fromincus storage list
for that project.The text was updated successfully, but these errors were encountered: