Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with URLSearchParams #22

Open
defaude opened this issue Aug 30, 2022 · 0 comments
Open

Doesn't work with URLSearchParams #22

defaude opened this issue Aug 30, 2022 · 0 comments

Comments

@defaude
Copy link

defaude commented Aug 30, 2022

See https://stackblitz.com/edit/js-gxcyih?file=index.js

I think it's because of the way we fall into the "plain" object comparison in https://github.com/lukeed/dequal/blob/master/src/index.js#L73-L80

const x = new URLSearchParams();
x.append("foo", "bar");

for (i in x) {
  if (x.hasOwnProperty(i)) console.info(i);
}

=> Nothing gets printed because e.g. entries is always the same, but the stuff returned from entries is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant