Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewriting ityped #5

Closed
felipe-campos opened this issue Jan 9, 2017 · 1 comment
Closed

Rewriting ityped #5

felipe-campos opened this issue Jan 9, 2017 · 1 comment

Comments

@felipe-campos
Copy link
Contributor

As I’ve said in my PR, I really liked your lib and thought I could contribute some tweaks.

As I started digging into it, I was struggling to distribute the ideas into concise and intuitive PRs. So, I decided to just write everything and then reach to you to check if you’re interested in seeing and discussing the changes in order to improve the overall result.

I wouldn’t say I’ve finished, but the code does work and it’s got smaller and easier, imho. It is 107 lines long right now.

What do you say?

Se quiser, podemos falar em português pelo FB. Vou deixar um comentário lá no seu post na JavaScript Brasil.

@luisvinicius167
Copy link
Owner

@felipe-campos Nice! Submit your PR :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants