Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is lightbox in unlikelyCandidatesRe? #93

Closed
wong2 opened this issue Aug 3, 2017 · 3 comments
Closed

Why is lightbox in unlikelyCandidatesRe? #93

wong2 opened this issue Aug 3, 2017 · 3 comments

Comments

@wong2
Copy link
Contributor

wong2 commented Aug 3, 2017

it's very likely to be an image right?

@haroldtreen
Copy link
Collaborator

I didn't write the original regex, but I'm assuming it helps remove galleries?

Have you found some sites that are broken from this? I haven't come across any issues with it.

Hopefully that answers, but feel free to reopen if you have an argument for changing it.

@wong2
Copy link
Contributor Author

wong2 commented Aug 4, 2017

@haroldtreen here is a bad case: https://zhuanlan.zhihu.com/p/28248770 the images are removed by node-readability due to the lightbox classname

@haroldtreen haroldtreen reopened this Aug 4, 2017
@haroldtreen
Copy link
Collaborator

Thanks for that example!

In that case, I'm open to removing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants