Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create single sound pool functioning across multiple backends #4

Open
cartertemm opened this issue Oct 16, 2019 · 4 comments
Open

Create single sound pool functioning across multiple backends #4

cartertemm opened this issue Oct 16, 2019 · 4 comments
Assignees
Labels
help wanted Extra attention is needed
Milestone

Comments

@cartertemm
Copy link
Collaborator

A sound_pool and it's functions rely heavily on instances of the sound class to do their dirtywork.
Aside from that, very little changes. slot reservations, function names, function signatures, etc etc.
With the status quo, we're writing custom pools for each and every backend. This seems like far too much unnecessary code.
If we leave the responsibility of conversions to each sound class, we could have a single sound pool that remains static regardless of internals. This would alleviate the need for

  • Writing extra code
  • Reinventing the wheel time and time again
  • Confusion

As long as the sound class, and I can't stress this enough, maintains our ranges and function signatures/operations in verbatim this would work. We shouldn't be dealing with a bunch of contrast here anyway.

@brightening-eyes
Copy link
Collaborator

we can have an abstract class for sound objects, and instanciate the provided backend and call through provided functions

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 20, 2019
@stale
Copy link

stale bot commented Nov 27, 2019

This issue has been closed due to inactivity.

@stale stale bot closed this as completed Nov 27, 2019
@pauliyobo
Copy link
Collaborator

Way to talk about issue resurrection. Anyway, reopening this issue, since it hasn't been fixed yet.

@pauliyobo pauliyobo reopened this Feb 18, 2021
@JessicaTegner JessicaTegner added this to the Lucia 2.0 milestone Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants