Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__win_check_git_update prints stdout, but not stderr on failure #598

Open
DrJKL opened this issue Apr 22, 2024 · 3 comments
Open

__win_check_git_update prints stdout, but not stderr on failure #598

DrJKL opened this issue Apr 22, 2024 · 3 comments

Comments

@DrJKL
Copy link

DrJKL commented Apr 22, 2024

Having an issue with git_helper.py disappearing and updates failing, the logs weren't very helpful.
Tracked it down to ~285 in manager_core.py where the stderr becomes _ and isn't printed in the "Fetch error: block below.

@ltdrdata
Copy link
Owner

I'm not exactly sure what situation you are describing.
Also, the line you indicated differs from the current line. Please update to the latest version and explain based on that.

@DrJKL
Copy link
Author

DrJKL commented Apr 23, 2024

Okay, made a minimal PR to demo:
#603

@DrJKL
Copy link
Author

DrJKL commented Apr 23, 2024

Probably should have gone with that in the first place :-D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants