Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to download books from playlists ! #354

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amit-gp
Copy link

@amit-gp amit-gp commented Jun 21, 2024

Hi folks ! Added the functionality to download books from entire playlists to the tool.

Resolves #344

  • Added a new flag --playlist which will interpret <BOOK-ID> as <PLAYLIST-ID>
  • Filters duplicates, videos, chapters, etc from playlists, and only downloads books
  • Reuses existing flow to download single books
  • Downloads books one at a time.
  • Also fixed a render issue with the logo on some systems by making it a raw string

[Potential future improvements]

  • Parallel downloads
  • Better overall project structure, we could now look into modularising the code better
  • Skip books already downloaded (Also helps with retries)

[Tested]

  • Existing flows like downloading single books
  • New flow with playlists + playlists with other media like videos
  • Works with enterprise accounts

I did not find a PR guideline / template, so do let me know if I can change anything !
Just used my best idea for integrating playlists with the flag approach.

Amit.

@amit-gp
Copy link
Author

amit-gp commented Jun 21, 2024

@lorenzodifuccia :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

download all books in specific playlist
1 participant