Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove race condition on tar file creation in utils.py #654

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Remove race condition on tar file creation in utils.py #654

merged 2 commits into from
Aug 10, 2022

Conversation

ramo-j
Copy link
Collaborator

@ramo-j ramo-j commented Aug 10, 2022

Closes #653

@ramo-j ramo-j requested a review from sydp August 10, 2022 01:41
@ramo-j ramo-j marked this pull request as ready for review August 10, 2022 01:41
@ramo-j ramo-j changed the title Remvoe race condition on tar file creation in utils.py Remove race condition on tar file creation in utils.py Aug 10, 2022
sydp
sydp approved these changes Aug 10, 2022
View reviewed changes
Copy link
Collaborator

@sydp sydp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ramo-j ramo-j merged commit f47ffe7 into log2timeline:main Aug 10, 2022
@ramo-j ramo-j deleted the i653 branch August 10, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydp sydp sydp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race condition in generating a compressed filename.
2 participants
@ramo-j @sydp