Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loco doctor should check for major recommended dep updates #900

Closed
jondot opened this issue Oct 23, 2024 · 0 comments
Closed

loco doctor should check for major recommended dep updates #900

jondot opened this issue Oct 23, 2024 · 0 comments
Milestone

Comments

@jondot
Copy link
Contributor

jondot commented Oct 23, 2024

Today's starters come with loco as a dependency, but since a starter is a vanilla Rust project, we leave some dependencies outlined in Cargo.toml to be used first-class by the developer and we don't "wrap and re-export" these deps.

Example dependencies are:

  • SeaORM
  • Axum
  • serde
  • etc.

While some dependencies are almost non-evolving (e.g. serde), and extremely stable (a good thing), other dependencies keep adding features and fixes (also a good thing!) such as SeaORM and Axum.

loco doctor should keep track of the dependencies that typically change, and that we want end users to change as well in their Cargo.toml in addition to updating the major loco version, and it should provide a listing of which deps to update and to which version.

myapp$ cargo loco doctor --dev

The following dependencies should be updated

Cargo.toml
- `sea-orm`: 1.1.0 -> 1.3.0
- `axum`: 0.7.0 -> 0.8.0

migration/Cargo.toml
- `sea-orm`: 1.1.0 -> 1.3.0

loco doctor should somehow know about which deps are important and which should be updated (maybe keep track of a list of deps, or extract the major deps on every build of master loco dep). Either way, it should be automatic, and resilient to errors/human error.

Note - it may be that we ditch the automatic method and just list out in CHANGELOG what deps to update, manually.


References

@jondot jondot added this to the 0.13.0 milestone Oct 28, 2024
@jondot jondot changed the title loco doctor should have a flag --upgrade to check for major recommended dep updates loco doctor should check for major recommended dep updates Oct 28, 2024
@jondot jondot closed this as completed Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant