Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Replace deprecated chrono::Duration::* #330

Merged
merged 1 commit into from
Jul 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/src/core/comms/secure_channel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ use std::{
sync::Arc,
};

use chrono::Duration;
use chrono::{Duration, TimeDelta};

use crate::crypto::{
aeskey::AesKey,
Expand Down Expand Up @@ -227,7 +227,7 @@ impl SecureChannel {
} else {
// Check if secure channel 75% close to expiration in which case send a renew
let renew_lifetime = (self.token_lifetime() * 3) / 4;
let renew_lifetime = Duration::milliseconds(renew_lifetime as i64);
let renew_lifetime = TimeDelta::try_milliseconds(renew_lifetime as i64).unwrap();
// Renew the token?
DateTime::now() - self.token_created_at() > renew_lifetime
}
Expand Down Expand Up @@ -373,7 +373,8 @@ impl SecureChannel {
/// Test if the token has expired yet
pub fn token_has_expired(&self) -> bool {
let token_created_at = self.token_created_at;
let token_expires = token_created_at + Duration::seconds(self.token_lifetime as i64);
let token_expires =
token_created_at + TimeDelta::try_seconds(self.token_lifetime as i64).unwrap();
DateTime::now().ge(&token_expires)
}

Expand Down
6 changes: 3 additions & 3 deletions lib/src/types/date_time.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use std::{
str::FromStr,
};

use chrono::{Duration, SecondsFormat, TimeZone, Timelike, Utc};
use chrono::{Duration, SecondsFormat, TimeDelta, TimeZone, Timelike, Utc};
use serde::{de::Error, Deserialize, Deserializer, Serialize, Serializer};

use crate::types::encoding::*;
Expand Down Expand Up @@ -167,7 +167,7 @@ impl From<i64> for DateTime {
} else {
let secs = value / TICKS_PER_SECOND;
let nanos = (value - secs * TICKS_PER_SECOND) * NANOS_PER_TICK;
let duration = Duration::seconds(secs) + Duration::nanoseconds(nanos);
let duration = TimeDelta::try_seconds(secs).unwrap() + Duration::nanoseconds(nanos);
Self::from(Self::epoch_chrono() + duration)
}
}
Expand Down Expand Up @@ -340,7 +340,7 @@ impl DateTime {
fn duration_to_ticks(duration: Duration) -> i64 {
// We can't directly ask for nanos because it will exceed i64,
// so we have to subtract the total seconds before asking for the nano portion
let seconds_part = Duration::seconds(duration.num_seconds());
let seconds_part = TimeDelta::try_seconds(duration.num_seconds()).unwrap();
let seconds = seconds_part.num_seconds();
let nanos = (duration - seconds_part).num_nanoseconds().unwrap();
// Put it back together in ticks
Expand Down
3 changes: 2 additions & 1 deletion samples/demo-server/src/machine.rs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ use std::sync::{
};

use chrono;
use chrono::TimeDelta;
use rand;

use opcua::server::{events::event::*, prelude::*};
Expand Down Expand Up @@ -214,7 +215,7 @@ fn raise_machine_cycled_event(
) {
// Remove old events
let now = chrono::Utc::now();
let happened_before = now - chrono::Duration::minutes(5);
let happened_before = now - TimeDelta::try_minutes(5).unwrap();
purge_events(
source_machine_id,
MachineCycledEventType::event_type_id(ns),
Expand Down
Loading