Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regenerate internals in pipeline #341

Closed
5 tasks done
AiyionPrime opened this issue Jun 18, 2024 · 1 comment
Closed
5 tasks done

regenerate internals in pipeline #341

AiyionPrime opened this issue Jun 18, 2024 · 1 comment

Comments

@AiyionPrime
Copy link
Contributor

AiyionPrime commented Jun 18, 2024

@locka99 Hey there,

first of all thanks for all the effort you've put into this project over the last years.
It appears to save me quite some time not needing to write an FFI for a cpp OPC UA library and hope you don't mind me rampaging through this project instead :S

Refactoring small stuff helps me figuring out how the project fits together;
one thing I'm currently having trouble wrapping my head around is how and when the five schema helpers

update
I found they were all formatted and added the five respective PRs with necessary minor fixes below.

are invoked to match the current code committed.

I suppose it should be a clean diff, when I regenerate and format the output?
If so I'd suggest (and eventually implement) a GitHub workflow, which regenerates the files and makes sure they do not change in order to tie the generators to the rest of the codebase?

This might furthermore help preventing unwanted fixes in generated code, which I might very well tripped in my open PRs.

I understand this is your freetime project? The open PRs are not meant as nudging, they only come in a bunch as I'll have more time to work on this in this week than usually. Sorry for all the buzz.

@AiyionPrime
Copy link
Contributor Author

AiyionPrime commented Jun 25, 2024

After reading about it in another issue, I implemented the workflow for gen_status_codes in #344.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant