Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C files are not rebuit when modified #38

Closed
schteve opened this issue Oct 13, 2022 · 1 comment · Fixed by #39
Closed

C files are not rebuit when modified #38

schteve opened this issue Oct 13, 2022 · 1 comment · Fixed by #39

Comments

@schteve
Copy link
Collaborator

schteve commented Oct 13, 2022

C files built through build.rs are not rebuilt when they are modified. The developer has to do something like cargo clean and then build again. There's also no warning or message that the C files are newer and may need to be rebuilt. This all results in the developer potentially building / running with out of date code and can easily cause confusing issues.

By default, Cargo doesn't know about files that are managed by build.rs so this makes sense. But it can be told about these files through cargo:rerun-if-changed. The files built through freertos-cargo-build should automatically have this applied if possible (at least shim.c but ideally also the FreeRTOS-Kernel source). There may be other files built by the user's build.rs through the inner cc, which should be left alone so the user can decide what to do.

@schteve
Copy link
Collaborator Author

schteve commented Oct 24, 2022

Closed by #39

@schteve schteve closed this as completed Oct 24, 2022
@schteve schteve linked a pull request Oct 24, 2022 that will close this issue
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant