Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about writing to rc files #5

Open
panckreous opened this issue May 2, 2024 · 1 comment
Open

Warn about writing to rc files #5

panckreous opened this issue May 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@panckreous
Copy link

I always find it nice when install scripts that want to make changes to any config files ask/warn first. In the future I figure there'll be a default install and an advanced install process that would ask me if I'd like it to write to any rc files automatically, else print out what I need to do manually.

For now, it'd be cool if there was an additional note during or after the install process telling users that whichever rc file was written to so if they manage their own dotfiles they know to go check it out and update manually if need be.

A message in that dimmed font color (grey for me), in the post-install message, something that makes sense to those who manage their own dots but doesnt scare those who don't. "lms was added to your $PATH", for example, may be all that's needed so you're not even potentially adding friction by saying a file was written to.

Overall, a pretty low-priority request in my opinion, but I was gushing too much in my previous comment and you're the ones who set the bar so high with all you've been doing anyways so...

(and feel free to close/ignore/etc if you disagree or dont want this left open)

@ryan-the-crayon
Copy link
Contributor

Hi, thanks for the suggestion. We will definitely consider it.

@ryan-the-crayon ryan-the-crayon added the enhancement New feature or request label May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants