Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme colors configuration #683

Open
orefalo opened this issue Aug 14, 2023 · 2 comments
Open

theme colors configuration #683

orefalo opened this issue Aug 14, 2023 · 2 comments
Labels
enhancement New features

Comments

@orefalo
Copy link
Contributor

orefalo commented Aug 14, 2023

Describe the problem:

other shells allow for precise color customizations, see below

# Syntax Highlighting Colors
set -U fish_color_normal $foreground
set -U fish_color_command $cyan
set -U fish_color_keyword $pink
set -U fish_color_quote $yellow
set -U fish_color_redirection $foreground
set -U fish_color_end $orange
set -U fish_color_error $red
set -U fish_color_param $purple
set -U fish_color_comment $comment
set -U fish_color_selection --background=$selection
set -U fish_color_search_match --background=$selection
set -U fish_color_operator $green
set -U fish_color_escape $pink
set -U fish_color_autosuggestion $comment

# Completion Pager Colors
set -U fish_pager_color_progress $comment
set -U fish_pager_color_prefix $cyan
set -U fish_pager_color_completion $foreground
set -U fish_pager_color_description $comment
set -U fish_pager_color_selected_background --background=$selection

Since shell users are console ASCII lovers, I would recommend allowing similar configurations in Murex.
I realize the ask goes beyond coloring, the prompt must be able to identify the type of arguments such as commands, pipes, redirections..etc which I believe it already does.

ie. Fish:

CleanShot 2023-08-14 at 09 58 29

vs Murex

CleanShot 2023-08-14 at 09 59 29
@orefalo orefalo added the enhancement New features label Aug 14, 2023
@lmorg
Copy link
Owner

lmorg commented Aug 14, 2023

Agreed. This is part of the long term plan. In fact that part of the code is already abstracted ready to expose: https://github.com/lmorg/murex/blob/master/utils/parser/parser.go

I don't have an ETA for it though. Do you see this as something of high importance?

@orefalo
Copy link
Contributor Author

orefalo commented Aug 14, 2023

No, coloring is low priority.

I am just going over all my fish scripts and trying to migrate them.

@lmorg lmorg added this to the v5.1 milestone Sep 6, 2023
@lmorg lmorg modified the milestones: v5.1, v5.2 Oct 1, 2023
@lmorg lmorg modified the milestones: v5.2, v5.3 Nov 5, 2023
@lmorg lmorg modified the milestones: v5.3, v5.4 Nov 28, 2023
@lmorg lmorg removed this from the v5.4 milestone Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features
Projects
None yet
Development

No branches or pull requests

2 participants