From e64cb2fbb7368bc0d45c46f927e705353e8c1882 Mon Sep 17 00:00:00 2001 From: lukasIO Date: Tue, 9 Aug 2022 12:43:38 +0200 Subject: [PATCH] Add fallback to unmunged sdp offer (#386) * add fallback to unmunged sdp offer * changeset --- .changeset/spotty-guests-type.md | 5 +++++ src/room/PCTransport.ts | 14 +++++++++++--- 2 files changed, 16 insertions(+), 3 deletions(-) create mode 100644 .changeset/spotty-guests-type.md diff --git a/.changeset/spotty-guests-type.md b/.changeset/spotty-guests-type.md new file mode 100644 index 000000000..7380bf9d4 --- /dev/null +++ b/.changeset/spotty-guests-type.md @@ -0,0 +1,5 @@ +--- +'livekit-client': patch +--- + +Add fallback to unmunged sdp offer diff --git a/src/room/PCTransport.ts b/src/room/PCTransport.ts index 96d6c4527..3e3beb480 100644 --- a/src/room/PCTransport.ts +++ b/src/room/PCTransport.ts @@ -134,10 +134,18 @@ export default class PCTransport { } }); - offer.sdp = write(sdpParsed); this.trackBitrates = []; - - await this.pc.setLocalDescription(offer); + const originalSdp = offer.sdp; + try { + offer.sdp = write(sdpParsed); + await this.pc.setLocalDescription(offer); + } catch (e: unknown) { + log.warn('not able to set desired local description, falling back to unmodified offer', { + error: e, + }); + offer.sdp = originalSdp; + await this.pc.setLocalDescription(offer); + } this.onOffer(offer); }