Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Comment Splits into Two When Typing in Vietnamese and Pressing Enter #1717

Closed
lamtuanamc opened this issue Jun 13, 2024 · 1 comment · Fixed by #1723
Closed

Bug: Comment Splits into Two When Typing in Vietnamese and Pressing Enter #1717

lamtuanamc opened this issue Jun 13, 2024 · 1 comment · Fixed by #1723
Assignees
Labels
bug Something isn't working

Comments

@lamtuanamc
Copy link

lamtuanamc commented Jun 13, 2024

Describe the bug

When using the comment feature in Liveblocks and typing in Vietnamese, if there are still underlined words (indicating that they are in the process of being composed), pressing Enter splits the comment into two. However, clicking the send button does not cause this issue.

To Reproduce

  1. Open the comment feature in Liveblocks.
  2. Start typing a comment in Vietnamese.
  3. Ensure that there are still underlined words (indicating that the words are being composed).
  4. Press Enter to submit the comment.

Expected behavior

The comment should be posted as a single comment regardless of whether the Enter key or the send button is used.

Actual Behavior:
When pressing Enter, the comment is split into two separate comments. When clicking the send button, the comment is posted as a single comment as expected.

Illustrations

Screen.Recording.2024-06-13.at.16.15.30.mov
@lamtuanamc lamtuanamc added bug Something isn't working triage needed The issue needs to be reviewed by the team labels Jun 13, 2024
@marcbouchenoire
Copy link
Contributor

Hi @lamtuanamc, thanks for the detailed report!

We'll investigate, and in the meantime could you try Entering on https://www.slatejs.org/examples/richtext and tell us if there are any unexpected behaviors? This is the text editor used in the Comments composer.

@marcbouchenoire marcbouchenoire self-assigned this Jun 14, 2024
@marcbouchenoire marcbouchenoire removed the triage needed The issue needs to be reviewed by the team label Jun 14, 2024
@marcbouchenoire marcbouchenoire added the triage needed The issue needs to be reviewed by the team label Jun 14, 2024 — with Linear
@marcbouchenoire marcbouchenoire removed the triage needed The issue needs to be reviewed by the team label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants