-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TABLE DDL with IDENTITY adds unnecessary DEFAULT #27
Comments
Thank you for reporting this. I'll fix it next week when I get back from travel. SnowDDL does not support The main problem with IDENTITY is the possibility for counter to be lost or broken during |
@Stegallo , please check version IDENTITY columns are now converted into sequences automatically. Current value and increment will be preserved. Sequence name is built using the following template: |
Describe the bug
I did run convert to create the yaml file of an existing table having an IDENTITY column.
The resulting yaml has
default: IDENTITY START 0 INCREMENT 1
.When I run the apply, the resulting DDL is syntactically invalid.
Not exactly sure if the issue is in the way the column gets converted or in the way the DDL is created.
If the latter, the fix may be as simple as conditionally remove the keyword DEFAULT in
https://github.com/littleK0i/SnowDDL/blob/master/snowddl/resolver/table.py#L170
Expected behavior
DEFAULT
keyword should not be present in column definition.Attach log
Attach YAML config (if applicable)
thank you!
The text was updated successfully, but these errors were encountered: