Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View Converter Fails There Is A Comment #108

Open
nickshffer opened this issue May 28, 2024 · 1 comment
Open

View Converter Fails There Is A Comment #108

nickshffer opened this issue May 28, 2024 · 1 comment

Comments

@nickshffer
Copy link

If a view has a comment then the converter will not properly parse the ddl.

The regex statement for parsing the view definition fails to find any matches if the view has a comment (which would come between the closing paren of the column defs and the \sas .

As a result, view_text is in effect the full body of the view ddl, which causes:

...
(
    message   =>  SQL compilation error:
syntax error line 18 at position 0 unexpected 'create'.
...
@littleK0i
Copy link
Owner

Please try 0.28.2. I've relaxed view parsing regexp a bit.

Unfortunately, there seems to be no way of getting "pure" SQL query text from Snowflake metadata, so current methods are prone to parsing errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants