Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make backers.svg lazy-loading #407

Closed
fuweichin opened this issue Dec 5, 2023 · 0 comments
Closed

Make backers.svg lazy-loading #407

fuweichin opened this issue Dec 5, 2023 · 0 comments

Comments

@fuweichin
Copy link

Eruda will request a thirdparty website when initializing, which may cause console error due to use of same-origin Cross-Origin-Embeder-Policy, or due to lack of internet connection, e.g.

GET https://opencollective.com/eruda/backers.svg?width=1536&exclude=true net::ERR_BLOCKED_BY_RESPONSE.NotSameOriginAfterDefaultedToSameOriginByCoep 200 (OK)

It's annoyning to see error for every reload when debugging. A mitigation measure is to add attribute loading="lazy" for that <img>.

Also note that requesting a thirdparty website may voilate users' privacy without notice.

@surunzi surunzi closed this as completed in e72fe4d Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant