Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unknow Account"-Email-Template is not showing email adress #5620

Open
pascalkienast opened this issue May 30, 2024 · 7 comments
Open

"Unknow Account"-Email-Template is not showing email adress #5620

pascalkienast opened this issue May 30, 2024 · 7 comments
Labels
Prio: Medium fixed and released with next scheduled release Type: Bug incorrect or uexpected behaviour

Comments

@pascalkienast
Copy link

pascalkienast commented May 30, 2024

URL: https://mein.berlin.de/accounts/password/reset/ (on prod!!)
user: any
expected behaviour: if you reset your password, but the email adress does not exist, you get an email with it (meinberlin/templates/account/email/unknown_account.de.email)
behaviour: see screenshot. the "{{ email }}" from the email template get replaced with an error code like <meinberlin.apps.users.adapters.UserAccountEmail object at 0x7fe185a58cd0>
important screensize: any
device & browser: any
Comment/Question: On A+-Prod this is working! - so, this is not an a4 issue i guess? .
Theoretically, this could be solved very quickly by simply removing the variable in the email template and no longer explicitly writing out the email address. But the better solution would be to look why mB can't access the email-variable

Bildschirmfoto 2024-05-30 um 14 59 49
@m4ra
Copy link
Contributor

m4ra commented May 30, 2024

mB prod has an updated django-allauth, which influenced some of our templates, this is not the case of a+ prod, as we haven't released any updates since last year. We caught during mB testing, the password _reset and verification_sent templates, but sadly not this one. @pascalkienast can you check if that's the case with unkown email also with aplus-dev, as we have merged the django-allauth updates there already.

@pascalkienast
Copy link
Author

pascalkienast commented May 30, 2024

@m4ra yes, on aplus-dev it is the same issue
Bildschirmfoto 2024-05-30 um 15 41 52

@goapunk goapunk added the Type: Bug incorrect or uexpected behaviour label May 30, 2024
@m4ra
Copy link
Contributor

m4ra commented May 30, 2024

OK, thank you, should we make a fix and a hotfix release for mB, after the a+ release? @CarolingerSeilchenspringer

@m4ra
Copy link
Contributor

m4ra commented May 30, 2024

@pascalkienast can you create the same issue in a+ and add it to the milestone Issue Story? thank you!

@CarolingerSeilchenspringer
Copy link
Contributor

@m4ra as there is a work around and edge case I would not do a hotfix release, next regular release is enough.

@CarolingerSeilchenspringer CarolingerSeilchenspringer added the Prio: Medium fixed and released with next scheduled release label May 31, 2024
@pascalkienast
Copy link
Author

@m4ra the issue is now also on a+ liqd/adhocracy-plus#2696

@m4ra
Copy link
Contributor

m4ra commented Jun 24, 2024

same issue with email "account already exists". @CarolingerSeilchenspringer
both will be fixed with what we did for aplus

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium fixed and released with next scheduled release Type: Bug incorrect or uexpected behaviour
Projects
None yet
Development

No branches or pull requests

4 participants