Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

streamline breakpoints & replace hardcoded values #5592

Open
hom3mad3 opened this issue Mar 4, 2024 · 1 comment
Open

streamline breakpoints & replace hardcoded values #5592

hom3mad3 opened this issue Mar 4, 2024 · 1 comment
Labels
Dev: Styling issue related to implementation of design Prio: Medium fixed and released with next scheduled release Type: Enhancement small improvements to site - less then half story point

Comments

@hom3mad3
Copy link
Contributor

hom3mad3 commented Mar 4, 2024

Issue Description:

Our scss code still uses old breakpoint values, and we're unsure if they'll match the new design for user-facing views. Plus, some parts of the new code is being declared using fixed numbers instead of flexible variables. We need to decide whether to keep using the old values or add new ones for the redesign, while ensuring everything still works for the dashboard.

Expected Behavior:
Figure out if we need new breakpoint values for the redesign, while also replacing fixed numbers with flexible variables throughout the code to make things easier to manage and compatible with both old and new designs.

Tasks:

  1. Ensure breakpoints adapt smoothly to redesign for both dashboard and user-facing views.
  2. Replace hardcoded values with variables for code flexibility.
  3. Check for differing breakpoints between dashboard and user-facing views, considering separate sets if needed.
@hom3mad3 hom3mad3 added Type: Enhancement small improvements to site - less then half story point Prio: Medium fixed and released with next scheduled release Dev: Styling issue related to implementation of design labels Mar 4, 2024
@goapunk
Copy link
Contributor

goapunk commented Apr 10, 2024

We should probably move this issue to the mb repo as we don't have any css in a4 directly

@hom3mad3 hom3mad3 transferred this issue from liqd/adhocracy4 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: Styling issue related to implementation of design Prio: Medium fixed and released with next scheduled release Type: Enhancement small improvements to site - less then half story point
Projects
None yet
Development

No branches or pull requests

2 participants