From ff5f993ad541463b7c4649250d59251ce1ffddd0 Mon Sep 17 00:00:00 2001 From: Michael Margolin Date: Thu, 2 May 2024 17:34:13 +0300 Subject: [PATCH] providers/efa: Rename bad op device completion status Align to device interface on work completion with unsupported operation error. This terminology is more accurate since this error can be related not only to an incorrect opcode. Reviewed-by: Daniel Kranzdorf Reviewed-by: Youssef Youssef Signed-off-by: Michael Margolin --- providers/efa/efa_io_defs.h | 4 ++-- providers/efa/verbs.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/providers/efa/efa_io_defs.h b/providers/efa/efa_io_defs.h index 9e9345e9d..dfcd484d7 100644 --- a/providers/efa/efa_io_defs.h +++ b/providers/efa/efa_io_defs.h @@ -34,8 +34,8 @@ enum efa_io_comp_status { EFA_IO_COMP_STATUS_FLUSHED = 1, /* Internal QP error */ EFA_IO_COMP_STATUS_LOCAL_ERROR_QP_INTERNAL_ERROR = 2, - /* Bad operation type */ - EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_OP_TYPE = 3, + /* Unsupported operation */ + EFA_IO_COMP_STATUS_LOCAL_ERROR_UNSUPPORTED_OP = 3, /* Bad AH */ EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_AH = 4, /* LKEY not registered or does not match IOVA */ diff --git a/providers/efa/verbs.c b/providers/efa/verbs.c index 9080daf1d..78636671b 100644 --- a/providers/efa/verbs.c +++ b/providers/efa/verbs.c @@ -449,7 +449,7 @@ static enum ibv_wc_status to_ibv_status(enum efa_io_comp_status status) case EFA_IO_COMP_STATUS_FLUSHED: return IBV_WC_WR_FLUSH_ERR; case EFA_IO_COMP_STATUS_LOCAL_ERROR_QP_INTERNAL_ERROR: - case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_OP_TYPE: + case EFA_IO_COMP_STATUS_LOCAL_ERROR_UNSUPPORTED_OP: case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_AH: return IBV_WC_LOC_QP_OP_ERR; case EFA_IO_COMP_STATUS_LOCAL_ERROR_INVALID_LKEY: