Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules still executing on files not listed in include? #23

Open
rohitpaulk opened this issue Jul 12, 2023 · 1 comment
Open

Rules still executing on files not listed in include? #23

rohitpaulk opened this issue Jul 12, 2023 · 1 comment

Comments

@rohitpaulk
Copy link

What our rule file looks like:

---
include: ["**/**.rb"]
---

Make sure our code follows these best practices, UNLESS there's a comment explaining why it's okay to break the rule.

1. Avoid typos.
2. Don't have like, really obvious bugs.
3. Follow reasonable conventions of the language we're programming in. No need to be too strict.

What the github integration mentions:

Screenshot 2023-07-12 at 07 12 59

Unsure if this means the check was a noop, or whether the file was actually analyzed for the rule.

@yeldarby
Copy link

Also having this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants