Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPIKE] Expose stats scoped by the caller service #2133

Closed

Conversation

fantayeneh
Copy link
Contributor

Signed-off-by: fantayeneh [email protected]

This PR not completed by far is to start the discussion on how we can expose
stats scoped by the caller service, which will help us to use linkerd as the source of truth for all service to service call metrics.

The idea is stolen from Matt Klein talk on Envoy.
svc2svc

Let me know if you're interested in this, or if there is a better way of achieving the same result.

Things to think about are

  • strategy to define who the caller is (maybe tracing headers can be used for this)
  • how to protect linkerd from the explosion of this stats

Fanta

@adleong
Copy link
Member

adleong commented Oct 1, 2018

Thanks @fantayeneh this is super interesting. This is pretty similar to some of the work that's being done in Linkerd2 to get per-source metrics.

I think a good first step before getting into the code would be to write up an issue describing what metrics Linkerd should output and describing the overall approach to how we determine the source.

@fantayeneh
Copy link
Contributor Author

Great, raised #2137
Will close this.

@fantayeneh fantayeneh closed this Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants