Add boundPath clientTls module. #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * *names* -- Required. A list of name matchers which each must contain: | ||
| * *prefix* -- A path prefix. All destinations which match this prefix | ||
| will use this entry to determine the common name. Wildcards are variable | ||
| capture are allowed (see: `io.buoyant.linkerd.util.PathMatcher`) |
There was a problem hiding this comment.
Wildcards and variable capture are allowed ?
|
lgtm based on my limited understanding of tls. 👍 ⭐ |
| capture are allowed (see: `io.buoyant.linkerd.util.PathMatcher`) | ||
| * *commonNamePattern* -- The common name to use for destinations matching | ||
| the above prefix. Variables captured in the prefix may be used in this | ||
| string. |
There was a problem hiding this comment.
At this point the bullet indentations are making documentation hard to read. (eg, here we are documenting commonNamePattern which is a required option for a list of names, which is a required option for a tls plugin, whose class name is specified as a required option for tls.) Let's make separate headered sections for each tls plugin
|
looks great! tioli: it could also be potentially useful to show some sample tls configurations in the docs, as this is one of the trickier config options ⭐ |
boundPath is a client tls module that allows you to determine the common name based on the destination bound path.
adleong
force-pushed
the
alex/bound-module
branch
from
4bda15a
to
785d815
Compare
|
Add example and rebase ⭐ |
|
woop woop 👍 |
adleong
added a commit
that referenced
this pull request
Feb 16, 2016
Add boundPath clientTls module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64
boundPath is a client tls module that allows you to determine the common name based on the destination bound path.
e.g.
HttpsIntegrationTest is also split up and refactored to reduce duplication.