Add TlsClientInitializer. #73
Conversation
|
TODO:
|
| * are sent. Note that while several TlsClientInitializer modules can be loaded, each router can only use at most | ||
| * one of them. | ||
| */ | ||
| trait TlsClientInitializers { |
There was a problem hiding this comment.
How about calling this file / trait / object TlsInitializers? That's my preference since it corresponds to the tls block from the config file.
Also, side note, mind wrapping all of your scaladoc comments at 80 chars?
There was a problem hiding this comment.
It's important to distinguish client tls from server tls...
I don't think the config should refer to clientTls since it's already set on the router and not the server...
I'm not saying this shouldn't be renamed, but I think we should be sensitive to distinguish client and server functionality in the naming
|
Excellent work, @adleong. This looks great. A minor quibble abut naming i'd like to resolve, but modulo that: ⭐ |
|
rebase, write a nice description, and good to go ;) |
A TlsClientInitializer will read configuration from the tls key in the router config and provide a TlsClientPrep module which is used to configure TLS in the client. Two TlsClientInitializers are provided: noValidation which skips hostname validation and static which uses a fixed hostname and optional CA cert for all clients.
adleong
force-pushed
the
alex/tls-config
branch
from
10fd959
to
65410fa
Compare
|
my name is oliver and i endorse this branch 👍 |
|
Looks good! And thanks for the scaladocs updates. ⭐ 🍵 |
Fixes #63
A TlsClientInitializer will read configuration from the tls key in the router
config and provide a TlsClientPrep module which is used to configure TLS in
the client. Two TlsClientInitializers are provided: NoValidationTlsClient
which skips hostname validation and StaticTlsClient which uses a fixed
hostname and optional CA cert for all clients.